Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses static analysis alerts from PVS-Studio across the DWC2 USB host controller driver, focusing on improving code clarity and addressing MISRA-C compliance warnings.
Key changes:
- Added explicit unsigned literal suffixes (0x01u, 0x02u) to prevent type promotion issues
- Converted implicit boolean checks to explicit comparisons for 1-bit bitfields
- Refactored if-else chains into switch statements for transfer type handling
- Introduced named constants (GUSBCFG_PHYSEL_, GUSBCFG_PHYHS_) for PHY configuration
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/portable/synopsys/dwc2/hcd_dwc2.c | Adds unsigned suffixes to literals, explicit comparisons for bitfields, refactors endpoint interval setup to switch statement, adds else branches with comments |
| src/portable/synopsys/dwc2/dwc2_type.h | Defines named enums for PHY selection and type to replace magic numbers |
| src/portable/synopsys/dwc2/dwc2_stm32.h | Changes while loop condition (introduces potential bug) |
| src/portable/synopsys/dwc2/dwc2_common.h | Converts implicit bitwise checks to explicit Yoda conditions |
| AGENTS.md | Expands developer documentation with detailed build/test instructions (contains path error) |
| .PVS-Studio/.pvsconfig | Adds suppression for hcint variable in interrupt handlers |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.