Fix in multiple example codes, wrong descriptor device qualifier length.#3357
Merged
HiFiPhile merged 2 commits intohathach:masterfrom Nov 21, 2025
Merged
Fix in multiple example codes, wrong descriptor device qualifier length.#3357HiFiPhile merged 2 commits intohathach:masterfrom
HiFiPhile merged 2 commits intohathach:masterfrom
Conversation
…tusb_desc_device_qualifier_t. Signed-off-by: Thomas Rubin <thomas.rubin2@protonmail.com>
HiFiPhile
approved these changes
Nov 21, 2025
Collaborator
HiFiPhile
left a comment
HiFiPhile
left a comment
There was a problem hiding this comment.
Thank you, device qualifer's length is indeed 10 bytes. Although this descriptor does nothing actually
Signed-off-by: HiFiPhile <admin@hifiphile.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not quite sure if it's actually wrong. I found that in five example codes the size of
tusb_desc_device_tis taken for thetusb_desc_device_qualifier_tlength field. In multiple other example codes the size of the actual structtusb_desc_device_qualifier_tis taken instead.But as I said, I'm not sure if it has some other background.