Skip to content

device/msc: skip command stage if EP out is stalled #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hathach merged 4 commits into from
Feb 12, 2026
+5 −1
Merged

device/msc: skip command stage if EP out is stalled #3471

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
697f6b3
device/msc: skip command stage if EP out is stalled
HiFiPhile Jan 26, 2026
b5c84aa
device/msc: only defer prepare_cbw() from STATUS_SENT when EP OUT sta…
Feb 11, 2026
8a8cea5
Merge pull request #3493 from hathach/pr-3471-status-sent-stall
hathach Feb 11, 2026
30802a1
Merge remote-tracking branch 'origin/master' into msc_stall
Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/class/msc/msc_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,12 @@ TU_ATTR_ALWAYS_INLINE static inline bool send_csw(mscd_interface_t* p_msc) {
TU_ATTR_ALWAYS_INLINE static inline bool prepare_cbw(mscd_interface_t* p_msc) {
uint8_t rhport = p_msc->rhport;
p_msc->stage = MSC_STAGE_CMD;
return usbd_edpt_xfer(rhport, p_msc->ep_out, _mscd_epbuf.buf, sizeof(msc_cbw_t), false);
// Skip command stage until Clear Stall request if endpoint is stalled
if (!usbd_edpt_stalled(rhport, p_msc->ep_out)) {
return usbd_edpt_xfer(rhport, p_msc->ep_out, _mscd_epbuf.buf, sizeof(msc_cbw_t), false);
} else {
return true;
}
}

static void fail_scsi_op(mscd_interface_t* p_msc, uint8_t status) {
Expand Down
Loading