feat: added arrows to scroll between images#56
Open
QyuBee wants to merge 1 commit intohatnote:masterfrom
Open
Conversation
Member
|
Hey @QyuBee that's great! For the record, Monumental is in a deprecated state due to being unable to find a maintainer. It seems you're comfortable enough with the code to modify it, and have been able to get it building, which is more than I can say for myself. If you're interested in continuing to use it, I'll just be forward and ask: would you be interested in taking over maintainership? I'm happy to help with deployment. For clarity, even if I merge this, I don't have an environment where I can build it in order to deploy it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add navigation arrows for image carousel
Description
In order to enhance user experience when navigating between images of a monument, I have added two arrow icons for easier navigation. These icons are linked to the
prevImage()andnextImage()functions. Previously, these functions were only accessible via the keyboard's "left arrow" and "right arrow" keys, which might not have been intuitive for new visitors.Changes
prevImage()andnextImage()functions.activate_scrollparameter in theopenImagefunction, allowing the arrows to only appear if there are multiple images available. This ensures that the navigation arrows are only displayed when useful.Screenshot
Here is a screenshot of the added arrow icons:

Impact
I hope this feature proves helpful in improving the user experience.