Skip to content

On http3, bind ipv6 for ipv6 #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hatoo merged 1 commit into from
Jan 6, 2026
Merged

On http3, bind ipv6 for ipv6 #839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/client_h3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ impl Client {
url: &Url,
) -> Result<Stream, ClientError> {
let endpoint_config = h3_quinn::quinn::EndpointConfig::default();
let local_socket = UdpSocket::bind("0.0.0.0:0").expect("couldn't bind to address");
let local_socket = if addr.0.is_ipv6() {
UdpSocket::bind("[::]:0").expect("couldn't bind to address")
} else {
UdpSocket::bind("0.0.0.0:0").expect("couldn't bind to address")
};
// If we can set the right build flags, we can use `h3_quinn::quinn::Endpoint::client` instead
let mut client_endpoint = h3_quinn::quinn::Endpoint::new(
endpoint_config,
Expand All @@ -106,11 +110,14 @@ impl Client {

let remote_socket_address = SocketAddr::new(addr.0, addr.1);
let server_name = url.host_str().ok_or(ClientError::HostNotFound)?;
dbg!(&remote_socket_address);
dbg!(&server_name);
let conn = client_endpoint
.connect(remote_socket_address, server_name)
.map_err(Http3Error::from)?
.await
.map_err(Http3Error::from)?;
dbg!("here");
Ok(Stream::Quic(conn))
}

Expand Down