Open
Conversation
Member
|
May I ask why this was needed in your game? Does it have long cut scenes or something like that? |
Contributor
Author
|
Yeah, we’ve got pretty long narrative sections and also because kids have a tendency to get briefly distracted and then frustrated when the device goes to sleep. I went down this route because the iOS target didn’t exhibit the same behaviour (via idleTimerDisabled), so made sense to standardise. However, definitely better if configurable across platforms. |
Member
|
That seems pretty reasonable. May happen a lot for games. Would you rebase this change on latest master? I have merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were asked to make sure the screen didn't go off during gameplay on Android. Whether or not this is desirable default behaviour, I'm unsure, however it does seem to be consistent with the iOS target, which seems sensible.