-
Notifications
You must be signed in to change notification settings - Fork 344
Use uv instead of poetry
#1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timrid
wants to merge
16
commits into
hbldh:develop
Choose a base branch
from
timrid:switch-to-uv
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use uv instead of poetry
#1934
+2,512
−3,091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`classifiers` and `dependencies` are defined in PEP621 and should be used instead of the legacy `[tool.poetry]` section.
`dependency-groups` is defined in PEP735 and should be used instead of the legacy `[tool.poetry.group.##]` section.
When using uv only the `dev` dependency group is installed by default. Using poetry by default all dependency groups are installed. So when switching from poetry to uv it is useful to add the `dev` group.
Newer Versions of bumble are breaking the tests. However, this has not been noticed yet, as the lock file has never been updated.
uv is creating a `.venv` folder in the repo root. This should be detected as default.
This fixes the following mypy error, which previously only occurred locally and not in CI. However, due to the switch to uv in CI, it now also occurs there. It is unclear why this did not occur in CI before. error: Cannot determine type of "open_transport_with_bluez_vhci" [has-type]
Poetry includes the LICENSE file automatically in the .whl and .tar.gz, but uv only includes it when it is explicilty marked in the pyproject.toml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1934 +/- ##
===========================================
+ Coverage 50.91% 51.04% +0.12%
===========================================
Files 39 39
Lines 3916 3916
Branches 479 479
===========================================
+ Hits 1994 1999 +5
+ Misses 1798 1794 -4
+ Partials 124 123 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In Github Actions sporadically the following exception is raise. This is probably because the pytest_cache folder was located on a mounted 9p file system. It is now stored outside the mounted folder in the hope that the problem will no longer occur. pytest.PytestCacheWarning: could not create cache path /home/builder/repo/.pytest_cache/v/cache/nodeids: [Errno 12] Out of memory: '/home/builder/repo/pytest-cache-files-_48ojim2'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from
poetrytouv, asuvis a more modern tool thanpoetryand also offers more possibilities.I haven't been able to test my changes to
.readthedocs.ymland.github/workflows/pypi-publish.ymlyet, as I don't know how to test them manually.This PR includes the changes from #1933.