DEFAULT_LOGIN_METHOD env for when mail otp isn't available (self-hosted)#7092
Open
gptlang wants to merge 2 commits intohcengineering:developfrom
Open
DEFAULT_LOGIN_METHOD env for when mail otp isn't available (self-hosted)#7092gptlang wants to merge 2 commits intohcengineering:developfrom
gptlang wants to merge 2 commits intohcengineering:developfrom
Conversation
Collaborator
|
Hello @gptlang , thanks for your contribution! |
lexiv0re
requested changes
Nov 4, 2024
Member
|
Just an idea, can we use SES url to determine if we should use OTP login method? If we don't have email service configured, then we should not have SES url and OTP is not possible. |
Collaborator
|
@aonnikov yeah, that's a good idea. I thought about this too and it appears we don't currently have SES url in our front service config file. So we'd have to add SES_URL to the front only to check whether OTP is supported or not. Why I probably would't want to expose it right now is that with the upcoming changes in the account we may immediately have other OTP delivery methods connected to various social logins other than email (e.g. telegram) so it might become a little bit tricky then. |
Signed-off-by: Antonio Cheong <acheong@duti.dev>
Signed-off-by: Antonio Cheong <acheong@duti.dev>
gptlang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When self hosting, SMTP isn't supported yet. The default email based login doesn't work. Login by email is just a click away but it would be easier if that could just be made default.
This change makes it such that we can simply add
to the environment to switch the defaults around.