Add default_builder configuration option#1796
Open
gregorw wants to merge 1 commit intoheartcombo:mainfrom
Open
Add default_builder configuration option#1796gregorw wants to merge 1 commit intoheartcombo:mainfrom
gregorw wants to merge 1 commit intoheartcombo:mainfrom
Conversation
For some CSS frameworks the current Simple Form configuration options are not enough. In particular, the error notification may require [additional nesting](https://github.com/abevoelker/simple_form_tailwind_css/blob/master/lib/simple_form/tailwind/error_notification.rb). But also data attributes on some wrappers may be [required](https://react.carbondesignsystem.com/?path=/story/components-textinput--playground&args=invalid:true). By introducing the `default_builder` configuration option any framework should be able to be configured. In the case of https://github.com/abevoelker/simple_form_tailwind_css this would allow to use ```erb <%= simple_form_for(@foo) do |f| %> ``` instead of ```erb <%= simple_form_for(@foo, builder: SimpleForm::Tailwind::FormBuilder) do |f| %> ```
|
This looks great to me, I don't see why it can't be merged in. Perhaps it needs some documentation on the README? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some CSS frameworks the current Simple Form configuration options are not enough. In particular, the error notification may require additional nesting. But also data attributes on some wrappers may be required. By introducing the
default_builderconfiguration option any framework should be able to be configured.In the case of simple_form_tailwind_css this would allow to use
instead of
See also #1723.