Open
Conversation
thechinedu
force-pushed
the
feature/coinbase-oauth-flow
branch
from
f6ecd7c to
19b4ac3
Compare
thechinedu
force-pushed
the
feature/coinbase-oauth-flow
branch
from
19b4ac3 to
7644861
Compare
Member
|
Nice! :-) |
samparsky
approved these changes
Apr 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds in coinbase as part of the oauth flow on the app
Note: This PR depends on heftybyte/tokens-api#101 which enables the coinbase oauth flow on the server. There are also some test config variables that need to be set in order for the oauth flow to work and this is available upon request.
Finally, the config variables being used are tied to my personal coinbase account, we should ideally switch this to a more appropriate account.