Open
Conversation
GregoireHebert
approved these changes
Jul 12, 2021
dunglas
force-pushed
the
feat/match-tags
branch
from
3ba627b to
bdec858
Compare
Author
|
@cpanato rebased, please double-check |
dunglas
force-pushed
the
feat/match-tags
branch
2 times, most recently
from
54b665c to
5f14712
Compare
Author
|
Fixed a rebasing issue. I manually tested the action and it works. |
I use this action to release the chart of [Mercure](https://mercure.rocks). We use a monolithic Git repository containing several projects, including the Helm chart. Currently, this action isn't compatible with our setup because it computes the changes made to the chart since the previous tag. In our case we also use tags for other projects in the same repository, so this actions is never triggered because there are no changes with the "previous" tag (which usually is for another project in the same repository). This PR introduces a `match_tags` option allowing to filter the tags to match using a glob. Signed-off-by: Kévin Dunglas <dunglas@gmail.com> Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
dunglas
force-pushed
the
feat/match-tags
branch
from
c45e611 to
02c7834
Compare
Author
|
I rebased again. Could you please merge this one? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use this action to release the chart of Mercure.
We use a monolithic Git repository containing several projects, including the Helm chart.
Currently, this action isn't compatible with our setup because it computes the changes
made to the chart since the previous tag.
In our case, we also use tags for other projects in the same repository,
so this actions is never triggered because there are no changes with the "previous" tag (which usually is for another project in the same repository).
This PR introduces a
match_tagsoption allowing to filter the tags to match using a glob.