Fix for Table which is came from other schema or other "dot implementation" purpose (like Postgre)#38
Open
rachyharkov wants to merge 3 commits intohermawanramadhan:masterfrom
Open
Fix for Table which is came from other schema or other "dot implementation" purpose (like Postgre)#38rachyharkov wants to merge 3 commits intohermawanramadhan:masterfrom
rachyharkov wants to merge 3 commits intohermawanramadhan:masterfrom
Conversation
Author
|
to see why this PR created, refer to this #37 , i'm also write up my discovery journey on it |
|
no one merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is from my friend's discovery, thanks to @muhazmi @FebriTahta for reporting this, I decided to fix it by myself but i'm stuck on searching and thinking what's should i do without tinkering the core file, and share what mybfound because the users of this library are from applications that have many database types set up on their applications are still relying on this might using dot symbol on option that define the table name