Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
===========================================
- Coverage 72.49% 51.47% -21.03%
===========================================
Files 302 296 -6
Lines 11007 10759 -248
===========================================
- Hits 7980 5538 -2442
- Misses 2152 4681 +2529
+ Partials 875 540 -335
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Some considerations:
|
5f9b15c to
be4a77e
Compare
scripts/manpages.go
Outdated
| s, _ := state.New(config.New()) | ||
| rootCommand := cli.NewRootCommand(s) | ||
|
|
||
| err := doc.GenManTree(rootCommand, nil, "./manpages") |
There was a problem hiding this comment.
The man pages have a 23-Jan-2026 Auto generated by spf13/cobra comment included. Is it possible to remove them, similar to how we are doing it for the markdown files?
cli/internal/scripts/generate_docs.go
Lines 52 to 72 in 097f2f0
There was a problem hiding this comment.
Additionally, could you have a look at the table output in man hcloud-config? It is pretty wonky right now.
|
The manpage output (as well as the generated markdown docs) would have a way better table view if the tables are printed using markdown format. Our table renderer already supports this, we just need to find a way to switch between the pretty print and markdown. I used a custom config option for now but it doesn't seem to work, because viper is not loaded if you only generate docs/manpages. I'll have a look at this another time. |
This PR adds the following package files to releases:
hcloud-cli-1.59.0-1.aarch64.rpmhcloud-cli-1.59.0-1.x86_64.rpmhcloud-cli_1.59.0_amd64.debhcloud-cli_1.59.0_arm64.deb