Skip to content

fix(external_link): noopenner should be noopener #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
D-Sketon merged 2 commits into from
Jan 3, 2026
+18 −18
Merged

fix(external_link): noopenner should be noopener #5729

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b0ddf0
fix(external_link): noopenner should be noopener
stevenjoezhang Jan 2, 2026
bab87b5
fix(external_link): update tests
stevenjoezhang Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/plugins/filter/after_post_render/external_link.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function externalLinkFilter(this: Hexo, data: RenderData): void {

if (rRelAttr.test(str)) {
str = str.replace(rRelStrAttr, (relStr, rel) => {
return rel.includes('noopenner') ? relStr : `rel="${rel} noopener"`;
return rel.includes('noopener') ? relStr : `rel="${rel} noopener"`;
});
return str.replace('href=', 'target="_blank" href=');
}
Expand Down
2 changes: 1 addition & 1 deletion lib/plugins/filter/after_render/external_link.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const rRelAttr = /rel=/i;
const rRelStrAttr = /rel=["']([^<>"']*)["']/i;

const addNoopener = (relStr: string, rel: string) => {
return rel.includes('noopenner') ? relStr : `rel="${rel} noopener"`;
return rel.includes('noopener') ? relStr : `rel="${rel} noopener"`;
};

function externalLinkFilter(this: Hexo, data: string): string {
Expand Down
Loading