Merged
Conversation
Implement ToJsonSchema trait for SchemaState with complete type mappings: - Basic types: Boolean, Null, Initial/Indefinite states - String types: All formats (UUID, Email, URL, Date variants, Hostname, RFC2822) - Number types: Integer and Float with ranges - Nullable types: Array syntax ["type", "null"] for nullable values - Complex types: Arrays with items/length constraints, Objects with required/optional fields - Document format: Complete JSON Schema 2020-12 documents with metadata Features: - Array type syntax for nullables (not anyOf unions) - Custom vendor extensions (x-drivel-type) for non-standard formats - Standard format mappings (UUID→uuid, Email→email, URL→uri, etc.) - Comprehensive edge case handling (empty objects, single values, negative ranges) Test coverage: 29 focused unit tests covering all type conversions and edge cases
- Create dedicated json_schema_tests module with submodules for different types - Split multi-case tests into individual focused test functions - Add helper functions to reduce boilerplate and improve readability - Maintain 100% test coverage with clearer, more maintainable organization
hgrsd
force-pushed
the
json-schema-feature
branch
from
4bf118c to
c2d1bfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a translation layer from the domain schema used internally by drivel to JSON schema (draft 2020-12).