Skip to content

Fix null check for public key parameter.#944

Open
dkocher wants to merge 1 commit intohierynomus:masterfrom
iterate-ch:issue/907-addendum
Open

Fix null check for public key parameter.#944
dkocher wants to merge 1 commit intohierynomus:masterfrom
iterate-ch:issue/907-addendum

Conversation

@dkocher
Copy link
Contributor

@dkocher dkocher commented May 14, 2024

Addendum for #908 as discussed in 1. Resolves #907.

Footnotes

  1. https://github.com/hierynomus/sshj/pull/908/files#r1600044608

@dkocher dkocher requested a review from hierynomus as a code owner May 14, 2024 17:07
@hierynomus
Copy link
Owner

Actually the null check is not for the parameter, but was once meant to only ensure that a subsequent call to init would not re-initialize. Need to check what the potential problem is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No initialization of public key depending on constructor usage of file key provider

2 participants