Fix page scrolling when using mouse wheel to zoom in Jupyter notebooks#194
Open
kaspermunch wants to merge 1 commit intohiglass:mainfrom
Open
Fix page scrolling when using mouse wheel to zoom in Jupyter notebooks#194kaspermunch wants to merge 1 commit intohiglass:mainfrom
kaspermunch wants to merge 1 commit intohiglass:mainfrom
Conversation
Adds a wheel event listener that prevents event propagation to the parent page while still allowing HiGlass to handle zoom interactions. This fixes the issue where scrolling to zoom in the HiGlass widget would also scroll the Jupyter notebook page, particularly when running notebooks in VS Code. The fix uses stopPropagation() with passive: false to intercept wheel events at the widget container level before they bubble up to the notebook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where scrolling the mouse wheel to zoom in the HiGlass widget would also scroll the Jupyter notebook page, particularly noticeable when running notebooks in VS Code.
Changes
wheelevent listener to the widget container that callsstopPropagation()to prevent the event from bubbling up to the notebook pagepassive: falseto ensure the event handler can properly intercept wheel eventsTesting
Technical Details
The fix is implemented in
src/higlass/widget.jsin theaddEventListenersTo()function, following the same pattern as the existingcontextmenuevent handler. This approach ensures wheel events are handled at the widget level before they can trigger page scrolling.🤖 Generated with Claude Code