Update global_vars.py to add self.refs instead of initialising later.#583
Merged
set-soft merged 1 commit intohildogjr:masterfrom Sep 5, 2025
ymich9963:master
Merged
Update global_vars.py to add self.refs instead of initialising later.#583set-soft merged 1 commit intohildogjr:masterfrom ymich9963:master
set-soft merged 1 commit intohildogjr:masterfrom
ymich9963:master
Conversation
Collaborator
|
This is Python, if a tool relies on such a thing then is incomplete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PartGroup currently there is no self.refs, but it gets initialised later in the code, see here,
KiCost/kicost/edas/tools.py
Line 159 in a67877e
For better readability and for helping dev tools (linters, autocomplete, etc.) to work properly I believe this commit necessary.