feat(http): unify extractor and predicate APIs for 0.3#202
Open
singulared wants to merge 1 commit intomainfrom
Open
feat(http): unify extractor and predicate APIs for 0.3#202singulared wants to merge 1 commit intomainfrom
singulared wants to merge 1 commit intomainfrom
Conversation
Introduce Config-based API for extractors and Into<Operation> shorthands for predicates, making the API more ergonomic and consistent. Extractors: - Add `extractor()` entry point function - Add Config types: MethodConfig, PathConfig, VersionConfig, HeaderConfig, QueryConfig, BodyConfig - Rename PathConfig::new() to PathConfig::pattern() - Re-export extension traits from extractors module Predicates: - Add Into<Operation> implementations for direct value usage - Allow `.method(Method::GET)` instead of `.method(method::Operation::eq(...))` - Allow `.status(StatusCode::OK)` instead of `.status(status::Operation::eq(...))` Breaking changes documented in hitbox-http/MIGRATION.md
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 80.18% 78.78% -1.41%
==========================================
Files 111 113 +2
Lines 7394 7594 +200
==========================================
+ Hits 5929 5983 +54
- Misses 1465 1611 +146 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce Config-based API for extractors and Into shorthands for predicates, making the API more ergonomic and consistent. closes #88
Extractors:
extractor()entry point functionPredicates:
.method(Method::GET)instead of.method(method::Operation::eq(...)).status(StatusCode::OK)instead of.status(status::Operation::eq(...))Breaking changes documented in hitbox-http/MIGRATION.md