Skip to content

Comments

Add support for conf/ folder configuration location#178

Merged
afalhambra-hivemq merged 2 commits intomasterfrom
feature/INT-30-conf-folder-support
Feb 4, 2026
Merged

Add support for conf/ folder configuration location#178
afalhambra-hivemq merged 2 commits intomasterfrom
feature/INT-30-conf-folder-support

Conversation

@afalhambra-hivemq
Copy link
Contributor

@afalhambra-hivemq afalhambra-hivemq commented Jan 30, 2026

Summary

  • Add support for placing azDiscovery.properties as config.properties in the conf/ subfolder of the extension home directory
  • Legacy location (extension root folder) still supported with a deprecation warning

Changes

  • Added ConfigResolver class to resolve configuration file location with legacy fallback
  • Updated ConfigReader to use ConfigResolver with CONFIG_PATH and LEGACY_CONFIG_PATH
  • Moved azDiscovery.properties to conf/config.properties subfolder in the extension ZIP
  • Added logback as implementation dependency for unit tests
  • Updated README to reference new config location
  • Updated all test references from STORAGE_FILE to LEGACY_CONFIG_PATH

Behavior

Scenario Result
Config only in conf/ Uses new location, no warning
Config only in root (legacy) Uses legacy location, logs WARN once
Config in both locations Uses legacy location, logs WARN once
No config file Extension logs warning (unchanged behavior)

Testing

  • Added ConfigResolverTest with 5 test cases covering all resolution scenarios
  • Added conf/ folder configuration test to ConfigReaderTest
  • Updated AzureDiscoveryExtensionIT to use new conf/ path
  • All unit tests pass

@cla-bot cla-bot bot added the cla-signed label Jan 30, 2026
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development January 30, 2026 12:37 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 2, 2026 14:52 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from 1aafcb5 to d277966 Compare February 2, 2026 15:50
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 2, 2026 15:50 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq self-assigned this Feb 2, 2026
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from d277966 to 7bbe1b8 Compare February 2, 2026 16:45
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 2, 2026 16:45 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from 7bbe1b8 to fde2bd3 Compare February 2, 2026 17:01
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 2, 2026 17:01 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from fde2bd3 to 7f3b985 Compare February 2, 2026 17:36
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 2, 2026 17:36 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from 7f3b985 to 509b079 Compare February 3, 2026 07:29
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 07:29 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from 509b079 to 38ee02a Compare February 3, 2026 07:29
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 07:29 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from 38ee02a to b9b3763 Compare February 3, 2026 07:36
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 07:36 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from b9b3763 to e5a463a Compare February 3, 2026 07:51
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 07:51 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from e5a463a to db7065b Compare February 3, 2026 07:54
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 07:54 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from db7065b to e6373d9 Compare February 3, 2026 07:54
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 07:54 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from e6373d9 to 1330602 Compare February 3, 2026 08:12
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 08:12 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from 1330602 to 606a100 Compare February 3, 2026 08:23
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 08:23 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from 606a100 to bcc4efd Compare February 3, 2026 08:26
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 08:26 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from a14105c to e580095 Compare February 3, 2026 09:14
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 09:14 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from e580095 to e12e72c Compare February 3, 2026 09:22
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 09:22 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 3, 2026 10:35 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from 59e50fe to a0aa858 Compare February 4, 2026 11:24
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 4, 2026 11:25 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from a0aa858 to 993341b Compare February 4, 2026 11:28
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 4, 2026 11:28 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from 993341b to 492bad1 Compare February 4, 2026 11:36
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 4, 2026 11:38 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from 492bad1 to a8cea91 Compare February 4, 2026 11:45
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 4, 2026 11:45 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/INT-30-conf-folder-support branch from a8cea91 to 07a84ec Compare February 4, 2026 16:17
@afalhambra-hivemq afalhambra-hivemq temporarily deployed to snyk-monitor-development February 4, 2026 16:17 — with GitHub Actions Inactive
Support both legacy (azDiscovery.properties) and new (conf/config.properties)
configuration paths based on extension version. Versions >= 1.2.8 use the new
path, while earlier versions use the legacy path.
@Donnerbart Donnerbart temporarily deployed to snyk-monitor-development February 4, 2026 17:41 — with GitHub Actions Inactive
@afalhambra-hivemq afalhambra-hivemq merged commit 353bc77 into master Feb 4, 2026
4 checks passed
@afalhambra-hivemq afalhambra-hivemq deleted the feature/INT-30-conf-folder-support branch February 4, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants