feat: Add SVG engine support for draggable node helper lines#679
Open
UmbraCi wants to merge 1 commit intohizzgdev:masterfrom
Open
feat: Add SVG engine support for draggable node helper lines#679UmbraCi wants to merge 1 commit intohizzgdev:masterfrom
UmbraCi wants to merge 1 commit intohizzgdev:masterfrom
Conversation
Contributor
Author
|
@hizzgdev 辛苦看下 |
hizzgdev
reviewed
Dec 14, 2025
| @@ -65,10 +65,14 @@ export class DraggableNode { | |||
| this.jm = jm; | |||
| /** @type {DraggableNodeOptions} */ | |||
| this.options = opts; | |||
Owner
There was a problem hiding this comment.
在传入的 option 里加一个参数,用于控制是否启用这个 feature,默认不要启用。等过段时间你用着没啥问题再修改默认值为 true.
参数名可以是: inheritViewEngine=false
| /** @type {CanvasRenderingContext2D|null} */ | ||
| this.canvas_ctx = null; | ||
| /** @type {SVGPathElement|null} */ | ||
| this.helper_line = null; |
| svg.setAttribute('class', 'jsmind-draggable-helper'); | ||
| svg.setAttribute('style', 'position: absolute; top: 0; left: 0; pointer-events: none;'); | ||
| this.jm.view.e_panel.appendChild(svg); | ||
| this.e_canvas = svg; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the draggable node plugin to use SVG for drawing helper lines when the SVG engine is enabled, improving performance for large-scale mind maps.
Changes
Modified Files
Key Features
Engine Detection
SVG Support
Backward Compatibility
Implementation Details
New Methods
Modified Methods
esize(): Handles sizing for both SVG and Canvas
Performance Benefits
SVG Engine:
Canvas Engine:
Code Reuse
Testing
Related Issues
Improves performance for large-scale mind maps (500+ nodes) when using SVG engine.
Checklist