Adds missing DEFINED in check for 64 bit system in CMakeLists.txt#53
Open
Jochen0x90h wants to merge 1 commit intohmartiro:masterfrom
Jochen0x90h:master
Open
Adds missing DEFINED in check for 64 bit system in CMakeLists.txt#53Jochen0x90h wants to merge 1 commit intohmartiro:masterfrom Jochen0x90h:master
Jochen0x90h wants to merge 1 commit intohmartiro:masterfrom
Jochen0x90h:master
Conversation
|
Good catch, I added in some checks of my own for MacOS as well as changed the default install location. I combined your commit in #57 I hope you don't mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to install into lib on a 64 bit system. For this I pass -DLIB_SUFFIX="" to CMake. This didn't work because NOT LIB_SUFFIX evaluates to false if LIB_SUFFIX is defined but empty string.