-
-
Notifications
You must be signed in to change notification settings - Fork 36.7k
Discord: Update nextcord version, improve error handling and logging,… #162327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
… replace blocking file reads by async ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
I wrote this change locally to help me get the discord integration working, initially I had targets unquoted which led to error tracebacks in the logs and it wasn't clear why. I also switched it to non-blocked file calls as notifications were filling my logs with warnings. |
epenet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the dependency in a (preliminary) standalone PR.
See https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr, section 7
When you need to bump a dependency, try to do so in a standalone PR.
Only compatibility code adjustments or small related bug fixes should be included in the PR.
If you have new features that depend on the updated dependency, these can be added in a follow-up.
This will also make CI iterations run a lot faster when reviewing the new features or larger bug fixes, as it restricts the tests to a single integration.
… replace blocking file reads by async ones
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: