Add explicit StrEnum conversions for D-Bus and Docker properties#6533
Draft
Add explicit StrEnum conversions for D-Bus and Docker properties#6533
Conversation
Convert string values from D-Bus and Docker API to their respective StrEnum types explicitly to satisfy typeguard runtime type checking. The conversions will raise ValueError if an unknown enum value is encountered, this will be caught in Sentry. Since D-Bus and the particular property from Docker API are not mission critical for Supervisor update functionality, it will be possible to add new enum values in the future as they arise. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert string values from D-Bus and Docker API to their respective StrEnum types explicitly to satisfy typeguard runtime type checking.
The conversions will raise ValueError if an unknown enum value is encountered, this will be caught in Sentry. Since D-Bus and the particular property from Docker API are not mission critical for Supervisor update functionality, it will be possible to add new enum values in the future as they arise.
Proposed change
Type of change
Additional information
Checklist
ruff format supervisor tests)If API endpoints or add-on configuration are added/changed: