fix(node-ws): fix WebSocket not working with app.route()#1623
Open
poteboy wants to merge 3 commits intohonojs:mainfrom
Open
fix(node-ws): fix WebSocket not working with app.route()#1623poteboy wants to merge 3 commits intohonojs:mainfrom
poteboy wants to merge 3 commits intohonojs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d90a14d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1623 +/- ##
=======================================
Coverage 84.41% 84.41%
=======================================
Files 120 120
Lines 3894 3895 +1
Branches 1052 1052
=======================================
+ Hits 3287 3288 +1
Misses 516 516
Partials 91 91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Contributor
nakasyou
reviewed
Jan 6, 2026
Contributor
nakasyou
left a comment
There was a problem hiding this comment.
Sorry for late reply. This is great idea to solve it, thank you.
Comment on lines
27
to
30
| const generateConnectionSymbol = () => Symbol('connection') | ||
|
|
||
| /** @example `c.env[CONNECTION_SYMBOL_KEY]` */ | ||
| const CONNECTION_SYMBOL_KEY: unique symbol = Symbol('CONNECTION_SYMBOL_KEY') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix WebSocket connections failing when the endpoint is registered under
app.route().Problem
When using
app.route(), WebSocket connections fail with400 Bad Request.Cause
The original implementation stored a connection symbol in
c.env:However, this doesn't persist when the WebSocket endpoint is registered via
app.route(). The exact reason is unclear, but it seemsc.envreference changes in that case.Solution
Instead of writing to
c.env, use aWeakSetto track therequestobject directly. Sincec.env.incoming(the request object) remains the same reference even throughapp.route(), this approach works reliably.The author should do the following, if applicable
yarn changesetat the top of this repo and push the changeset