fix(zod-validator): improve type inference for partial schemas#1724
Open
dyyz1993 wants to merge 2 commits intohonojs:mainfrom
Open
fix(zod-validator): improve type inference for partial schemas#1724dyyz1993 wants to merge 2 commits intohonojs:mainfrom
dyyz1993 wants to merge 2 commits intohonojs:mainfrom
Conversation
- Remove HasUndefined check from DefaultInput type - This ensures Hono RPC can correctly infer json parameter type - Fixes issue where schema.partial() breaks client type inference Co-Authored-By: Claude <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: be82f3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1724 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 112 112
Lines 3734 3734
Branches 946 946
=======================================
Hits 3461 3461
Misses 245 245
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Hono RPC type inference issue when using zValidator with partial schemas (e.g.,
schema.partial()).Problem
When using
zValidator('json', schema.partial()), thejsonfield becomes optional in the middleware's Input type becauseHasUndefined<In>returnstruewhen all fields are optional. This causes Hono RPC to not infer thejsonparameter for the client.Solution
Remove the
HasUndefinedcheck fromDefaultInputtype definition. This ensures:jsonfield itself is always required in the Input typejsoncan still be optional (e.g.,{ name?: string })Test Plan
Breaking Changes
None. The validation behavior remains unchanged; only the type inference is improved.