fix: align ISwap interface to Swap implementation#95
Closed
charlesndalton wants to merge 1 commit intohop-protocol:masterfrom
Closed
fix: align ISwap interface to Swap implementation#95charlesndalton wants to merge 1 commit intohop-protocol:masterfrom
charlesndalton wants to merge 1 commit intohop-protocol:masterfrom
Conversation
Contributor
|
@red-impala check out the contracts/contracts/saddle/Swap.sol Line 317 in 8cefc39 @cwhinfrey @shanefontaine wondering if we should default to edit: was looking at the wrong file but the PR is still valid I think for v1 branch |
Author
|
@miguelmota Ok, will create the PR on v1 since I see it has the same problem |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.