Open
Conversation
uidp
approved these changes
Feb 12, 2026
| deletionRequest, | ||
| }); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I'm wondering if this functionality couldn't be implemented in one single place so that both UCs can use it. But user and account do actually live in different modules and maybe writing a sperate service for that would be overkill. Just a thought.
|
|
||
| public static deletedFilter(query: UserSearchQuery, deletionDate?: Date): void { | ||
| query['$or'] = [{ deletedAt: { $exists: false } }, { deletedAt: null }, { deletedAt: { $gte: deletionDate } }]; | ||
| } |
Contributor
There was a problem hiding this comment.
Just a minor thought about naming: Maybe better use an imperative name like setDeletionFilter to be consistent with the other functions?
| const user = await this.findById(userId); | ||
| user.deletedAt = deletedAt ?? new Date(); | ||
| this._em.persist(user); | ||
| await this._em.flush(); |
Contributor
There was a problem hiding this comment.
We could even bypass the entity manager and use a native query.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
BC-11265
hpi-schul-cloud/nuxt-client#4077
hpi-schul-cloud/schulcloud-client#3756
Changes
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.