Open
Conversation
made changes so that I can do "import odespy" at an IPython terminal without any errors. Changes made are in CHANGES_FOR_PY36.md.
Tests run, with a few failures. All related to the StaggeredMidpoint solver. The same errors occur in py27. So not specific to py36.
Runs with all deps in requirements.txt; and without any deps (i.e., only Numpy, and scipy). In Py27, Py35 and Py36.
Using pip the setup doesn't compile fortran extensions. Either pip -e (which runs python setup.py develop) or directly running python setup.py install is required. To enable the former in tox we need to use these two options.
In Py3 we can use func(*args, **kwargs), which is also valid in Py2.
|
how do I get your files to work with the latest jupyter notebook? I am unable to use python 2.7 for some reason |
Author
|
Sorry for the late reply. Can you be more specific about the errors you get? I am able to run tests in Python 2.7 and 3.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have made some changes to the code to make it run under Python 3.6. The code now runs under 2.7, 3.5 and 3.6.
Please see the file
CHANGES_FOR_PY36.mdfor a list of changes.I have setup up Tox so that it is easy to run tests under different versions of Python (see tox.ini).
The tests succeed for all but the StaggeredMidpoint algorithm. This failures is present in all versions
of Python. So it seems like there is a bug in the algorithm. If you could let me know a fix I will
incorporate it into this pull request.
Regards,
Prasanth