Add testcase: Incorrectly opened comment in script data#169
Open
untitaker wants to merge 2 commits intohtml5lib:masterfrom
Open
Add testcase: Incorrectly opened comment in script data#169untitaker wants to merge 2 commits intohtml5lib:masterfrom
untitaker wants to merge 2 commits intohtml5lib:masterfrom
Conversation
lol-html fails this testcase because its "tokenizer" aims to be too smart and infers state change based on script data. It's a problem with their test harness because they run the wrong layer of abstraction IMO. I just sort of winged the line/col information, it would be good to get those CI PRs merged so there's some sanity checks.
Contributor
Author
|
@fb55 i see this testcase does not pass for parse5, but i think it should |
Contributor
|
Test case makes sense to me, seems to be an issue in parse5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lol-html fails this testcase because its "tokenizer" aims to be too
smart and infers state change based on script data. It's a problem with
their test harness because they run the wrong layer of abstraction IMO.
I just sort of winged the line/col information, it would be good to get
those CI PRs merged so there's some sanity checks.