change the Oracle select to use OFFSET...FETCH#231
Open
zhangyongding wants to merge 2 commits intohuandu:masterfrom
Open
change the Oracle select to use OFFSET...FETCH#231zhangyongding wants to merge 2 commits intohuandu:masterfrom
zhangyongding wants to merge 2 commits intohuandu:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes Oracle pagination by replacing the legacy ROWNUM-based approach with the standard OFFSET...FETCH syntax (introduced in Oracle 12c). This brings Oracle's SQL generation in line with modern SQL standards and simplifies the codebase.
Changes:
- Removed complex ROWNUM-based pagination logic from select.go
- Implemented OFFSET...FETCH syntax for Oracle in select.go (matching the already-updated union.go)
- Updated test expectations in select_test.go to reflect the new Oracle query format
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| select.go | Replaced ROWNUM-based pagination with OFFSET...FETCH syntax; removed unused strings import and ~50 lines of complex nested query logic |
| select_test.go | Updated Oracle test expectations to show the new OFFSET...FETCH query format instead of ROWNUM queries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Can it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.