Distinct array or object by keeping a empty array literal#164
Open
GHolk wants to merge 1 commit intohughsk:masterfrom
Open
Distinct array or object by keeping a empty array literal#164GHolk wants to merge 1 commit intohughsk:masterfrom
GHolk wants to merge 1 commit intohughsk:masterfrom
Conversation
Make `{a: [1,2]}` produce `{a: [], 'a.0': 1, 'a.1': 2}`,
so we can distinct array and object.
Add a `opts.useEmptyArray` option to turn on this feature.
GHolk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The numeric keys is ambiguous, which could mean object keys or array indice.
If
flattenfunction output a empty array for a array, it would be precise the numeric keys mean the array indice.Eg:
{a: [1,2]}is flatten to{a: [], 'a.0': 1, 'a.1': 2},and
{a: {'0': 1, '1': 2}}is flatten to{'a.0': 1, 'a.1': 2},so we can distinct array and object.
A new option
useEmptyArraywill to turn on this feature.This is similar to the
safeoption, but the values in array still get flatten.The docs and the tests are not updated yet, and this seem to cause some side effects on flatten object while
unflatten.I will update them if hughsk is interested in merging this feature.
Somewhat relate to #74 .