feat: directory rename #732
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request significantly enhances the S3 stream wrapper by adding robust support for renaming directories (not just files) within S3 buckets, ensuring correct handling of special characters in object keys (such as spaces and parentheses), and improving test coverage for these scenarios. The update introduces batch operations for efficient directory renames and adds comprehensive tests to verify correct behavior and encoding.
Major enhancements to S3 stream wrapper directory rename functionality:
isDirectoryPrefixhelper to accurately detect when a given key represents a directory (prefix) in S3, ensuring the correct rename logic is applied.encodeCopySourcemethod to correctly URL-encode each path segment for S3'sCopySourceparameter, preventing failures when object keys contain spaces or special characters.Test improvements and validation:
encodeCopySourcemethod is used in the directory rename implementation and that file renames with special characters succeed.Dependency update:
Aws\CommandPoolto enable batch operations for copying objects in directory renames.