Return a mock scheduled event object when preventing cron scheduling#720
Open
kadamwhite wants to merge 1 commit intoprevent-cron-frontendfrom
Open
Return a mock scheduled event object when preventing cron scheduling#720kadamwhite wants to merge 1 commit intoprevent-cron-frontendfrom
kadamwhite wants to merge 1 commit intoprevent-cron-frontendfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussion in #702, this PR proposes an alternative return value which effectively prevents event scheduling.
In almost all cases within Core
truewould have been a valid value fortimestamp, as it is almost always used in purely boolean checks. However there are one or two specific instances (wp_version_check, e.g.) where the timestamp is used in a numeric comparison. Returning an object with a timestamp perpetually one hour in the future feels like a viable hack to prevent event rescheduling.