Skip to content

Update RouterGuide.md #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adam-fowler merged 2 commits into from
Mar 9, 2025
Merged

Update RouterGuide.md #83

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebe9e9b
Update RouterGuide.md
JoachimM7 Mar 9, 2025
327bc86
Update RouterGuide.md
JoachimM7 Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions Hummingbird.docc/Articles/RouterGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,15 @@ Route handlers are required to return a type conforming to the `ResponseGenerato
extension String: ResponseGenerator {
/// Generate response holding string
public func response(from request: Request, context: some RequestContext) -> Response {
let buffer = context.allocator.buffer(string: self)
return Response(status: .ok, headers: ["content-type": "text/plain; charset=utf-8"], body: .byteBuffer(buffer))
let buffer = ByteBuffer(string: self)
return Response(
status: .ok,
headers: .defaultHummingbirdHeaders(
Copy link
Member

@adam-fowler adam-fowler Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could change it to this

headers: [.contentType: "text/plain; charset=utf-8"],

contentType: "text/plain; charset=utf-8",
contentLength: buffer.readableBytes
),
body: .init(byteBuffer: buffer)
)
}
}
```
Expand Down Expand Up @@ -246,4 +253,4 @@ router.post("test") { request, _ -> EditedResponse in
- ``HummingbirdCore/Response``
- ``Router``
- ``RouteCollection``
- ``RouterGroup``
- ``RouterGroup``