Conversation
Hummingbird.docc/Articles/JSON.md
Outdated
| @@ -0,0 +1,21 @@ | |||
| # JSON Support | |||
|
|
|||
There was a problem hiding this comment.
Do we need a separate page just for JSON?
Perhaps we can change the byline for the Encoding and Decoding article to make it clearer that it is the how you decode JSON data.
There was a problem hiding this comment.
eg "Support for decoding and encoding JSON and other file formats with Codable"
There was a problem hiding this comment.
For a newcomer to Hummingbird 2 and Swift, I feel that En/Decoding doesn't really tag onto what you want to do. People want to send/receive JSON, they "don't care" that this requires Codable.
There was a problem hiding this comment.
I would prefer we fix the naming of encoding/decoding docs instead of repeating what is pretty much the same content in this JSON doc.
adam-fowler
left a comment
There was a problem hiding this comment.
I happy with all the other changes. Still not convinced by JSON page. I've tried to ameliorate some of your concerns with #87. They make it a lot clearer that they are about JSON encoding/decoding
adam-fowler
left a comment
There was a problem hiding this comment.
You've still got the json link in index.md
Co-authored-by: Adam Fowler <adamfowler71@gmail.com>
Co-authored-by: Adam Fowler <adamfowler71@gmail.com>
79cf45f to
ed6203e
Compare
No description provided.