Merged
Conversation
Joannis
reviewed
Aug 6, 2025
| /// create new key with value. If key already exist throw `PersistError.duplicate` error | ||
| public func create(key: String, value: some Codable, expires: Duration?) async throws { | ||
| let expiration: SET<ByteBuffer>.Expiration? = expires.map { .milliseconds(Int($0 / .milliseconds(1))) } | ||
| let jsonBuffer = try ByteBuffer(bytes: JSONEncoder().encode(value)) |
Member
There was a problem hiding this comment.
Shouldn't we try to serialize to RESP instead?
Member
Author
There was a problem hiding this comment.
The SET command only takes a buffer/string for a value, serialising to RESP isn't possible here.
Member
Author
There was a problem hiding this comment.
I guess the value string could be RESP. But I'm not sure I see any advantage to that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means we ditch most of the code.
And we are left with just the persist driver