Print the server's scheme when logging that it's reachable

[Joannis]

No description provided.

[Joannis]

Not sure if we can make this change - but I think it would be nice to log the scheme as described in #578. We can also assume HTTP (not HTTPS) here, but I'd prefer logging it correctly.

[Joannis]

We can also consider detecting if the IP is :: or 0.0.0.0 so that we can print more accurate info

[github-actions]

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-10-13T17:26:54+00:00

[adam-fowler]

Seems a bit of overkill just to print http or https.
Could you not just check the first channel handler is NIOSSLServerHandler

[Joannis]

Unfortunately no, as TransportServices does not have a handler, and these handlers are only applicable for child channels of the server

[github-actions]

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-10-14T15:45:26+00:00

[adam-fowler]

I'm not sure what the point of this is? Why do you want to print 127.0.0.1 when the bind address is 0.0.0.0

[Joannis]

@adam-fowler my idea was that I want to (eventually) make it explicit how to reach it from various devices. Should've explained that in the PR.

So 0.0.0.0 should also render into your LAN IP and 127.0.0.1

[adam-fowler]

@Joannis But bind address 0.0.0.0 is different from 127.0.0.1, ie one accepts connections from any address while the other accepts only connections from the localhost. We shouldn't be pretending they are the same.

Maybe if the bind address is set to 0.0.0.0 then we can add an additional log that says it is accepting connections from anywhere

[Joannis]

I understand what 0.0.0.0 does, but it's not common knowledge. By adding logs about the available addresses to connect to, I'm hoping to address that knowledge gap so that people understand how this works. Or more importantly, how they can test their app.

[Joannis]

An excellent example that I've had people ask time and time again:

How do I connect to my backend from an iOS app? 127.0.0.1 doesn't work.

[adam-fowler]

You need an additional log item then, because the people who do know what is going on are going to be a little confused when there server logs says the server is listening on 127.0.0.1 but accepting connections from anywhere.

An excellent example that I've had people ask time and time again:

How do I connect to my backend from an iOS app? 127.0.0.1 doesn't work.

Also can we make it clear which situation we are trying to fix here, as your change doesn't fix this.