Skip to content

Omit lowercasing components and paths, and opt for case insensitive comparisons instead #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Joannis wants to merge 2 commits into
base: main
Choose a base branch
from

Try the whole of Foundation for now

9da9b0a
Select commit
Loading
Failed to load commit list.
Draft

Omit lowercasing components and paths, and opt for case insensitive comparisons instead #749

Try the whole of Foundation for now
9da9b0a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 9, 2025 in 0s

83.42% (-0.38%) compared to 5bd2a4b

View this Pull Request on Codecov

83.42% (-0.38%) compared to 5bd2a4b

Details

Codecov Report

❌ Patch coverage is 51.66667% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.42%. Comparing base (5bd2a4b) to head (9da9b0a).

Files with missing lines Patch % Lines
Sources/Hummingbird/Router/RouterPath.swift 0.00% 26 Missing ⚠️
Sources/Hummingbird/Router/Trie/Trie+resolve.swift 92.85% 2 Missing ⚠️
Sources/Hummingbird/Router/TrieRouter.swift 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
- Coverage   83.79%   83.42%   -0.38%     
==========================================
  Files         117      117              
  Lines        5993     6034      +41     
==========================================
+ Hits         5022     5034      +12     
- Misses        971     1000      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov