Merged
Conversation
thoven87
reviewed
Jan 6, 2025
thoven87
reviewed
Jan 6, 2025
Contributor
thoven87
left a comment
thoven87
left a comment
There was a problem hiding this comment.
Looks there are some conflicts that need to be resolved.
The link can either be the span context at the point jobQueue.push was called or the previous attempt at running this job.
thoven87
approved these changes
Jan 7, 2025
Joannis
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trace context of the current span is stored in the job metadata and then added as a link to the job span. This means you get a link to the span that triggered the job which could either be the original http request, or the previously failed attempt.