chore: Bump required rust-toolchain version#949
Open
ESHARK22 wants to merge 9 commits intohyperion-mc:mainfrom
Open
chore: Bump required rust-toolchain version#949ESHARK22 wants to merge 9 commits intohyperion-mc:mainfrom
ESHARK22 wants to merge 9 commits intohyperion-mc:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Bumps the required Rust nightly toolchain and adjusts unstable feature gates to align with newer compiler capabilities.
- Update nightly toolchain date (2025-02-22 -> 2025-06-26)
- Remove obsolete/unneeded feature gate slice_as_chunks
- Introduce new unstable feature gates (duration_constructors_lite, generic_const_exprs) and an expect attribute for incomplete_features
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rust-toolchain.toml | Bumps nightly channel date to a newer toolchain. |
| crates/simd-utils/src/lib.rs | Removes now-unneeded slice_as_chunks feature gate. |
| crates/hyperion/src/lib.rs | Adds duration_constructors_lite unstable feature gate. |
| crates/hyperion-proxy/src/lib.rs | Adds generic_const_exprs feature and expect attribute for incomplete features. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
I have not tested this much other that for my small, personal projects. There may be unknown side effects. |
Collaborator
|
Should we allow |
ESHARK22
added a commit
to ESHARK22/hyperion
that referenced
this pull request
Oct 3, 2025
See hyperion-mc#949 (comment) "f32::midpoint generates more instructions, and float underflow/overflow isn't an issue we need to handle in general."
See hyperion-mc#949 (comment) "f32::midpoint generates more instructions, and float underflow/overflow isn't an issue we need to handle in general."
Addresses the follwing clippy error:
'''
error: this `if` statement can be collapsed
--> crates/hyperion-clap-macros/src/lib.rs:14:9
|
14 | / if attr.path().is_ident("command_permission") {
15 | | if let Err(err) = attr.parse_nested_meta(|meta| {
16 | | if meta.path.is_ident("group") {
17 | | if let Ok(Lit::Str(lit)) = meta.value()?.parse::<Lit>() {
... |
27 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `-D clippy::collapsible-if` implied by `-D clippy::style`
= help: to override `-D clippy::style` add `#[allow(clippy::collapsible_if)]`
help: collapse nested if block
|
14 ~ if attr.path().is_ident("command_permission")
15 ~ && let Err(err) = attr.parse_nested_meta(|meta| {
16 | if meta.path.is_ident("group") {
...
25 | .into();
26 ~ }
|
'''
Fixes clippy::io-other-error
Fixes clippy::borrow_as_ptr (https://rust-lang.github.io/rust-clippy/master/index.html#borrow_as_ptr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a newer rust-toolchain nightly version as some dependencies may require a higher MSRV