server: Ignore NotConnected errors on shutdown#654
Closed
LucioFranco wants to merge 2 commits intomasterfrom
Closed
server: Ignore NotConnected errors on shutdown#654LucioFranco wants to merge 2 commits intomasterfrom
NotConnected errors on shutdown#654LucioFranco wants to merge 2 commits intomasterfrom
Conversation
hawkw
approved these changes
Dec 14, 2022
Collaborator
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
i think it seems fine to ignore the error in this case. the idea of completely ignoring an error makes me mildly uncomfortable, so maybe we should be logging it? otherwise, lgtm.
Member
|
I'm not so sure we should choose to ignore the error. We don't know the full context of the IO transport. It feels more correct to me to pass that error along to the user, and they can decide if to ignore it or not. |
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
|
seems to be more or less the same changes i proposed in #653 |
Member
Author
Sounds good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to hyperium/tonic#1183
I started to see this error come up when debugging the above tonic issue, to me ignoring this error seems okay in this context, but I'd like to have some other eyes on it.
cc @seanmonstar @hawkw