fix(tonic-web): fix dropped trailers in combined streaming call.#2474
Open
zakhenry wants to merge 1 commit intohyperium:v0.14.xfrom
Open
fix(tonic-web): fix dropped trailers in combined streaming call.#2474zakhenry wants to merge 1 commit intohyperium:v0.14.xfrom
zakhenry wants to merge 1 commit intohyperium:v0.14.xfrom
Conversation
c3d84d7 to
1a0acf3
Compare
Contributor
Author
|
note the CI failure is which is not related to my diff. |
1a0acf3 to
75e8179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In testing grpc-web streaming from AWS lambda I discovered a bug in the trailer frame parsing where if the upstream service combined data frames together (message + trailers in the same frame), the trailers would be dropped.
Solution
In tonic web frame decoding logic, ensure trailers are emitted on poll even when the data frame has been emitted.