Draft
Conversation
ecb179f to
d376728
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the test infrastructure by unignoring and refactoring several tests that no longer need to be run in isolation. The tests are updated to be more robust against concurrent execution and race conditions.
Changes:
- Unignored and simplified four tests:
test_trace_trace,create_200_sandboxes(reduced from 1000),test_drop, andexecute_on_heap - Improved test implementations to handle concurrent execution better by using unique sizes, exact mapping checks, and clearer assertions
- Removed unused
build_metadata_testingmodule fromlog_values.rs
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/rust_guests/simpleguest/src/main.rs | Updated return value for execute_on_heap to match new test expectations |
| src/hyperlight_host/tests/integration_test.rs | Removed #[ignore] attribute and improved assertions for execute_on_heap test |
| src/hyperlight_host/src/testing/log_values.rs | Removed unused build_metadata_testing module |
| src/hyperlight_host/src/sandbox/uninitialized.rs | Removed #[ignore] and refactored test_trace_trace with cleaner helper functions and better documentation |
| src/hyperlight_host/src/sandbox/initialized_multi_use.rs | Removed #[ignore] and reduced test from 1000 to 200 sandboxes with clearer variable naming |
| src/hyperlight_host/src/mem/shared_mem.rs | Removed #[ignore] and improved test_drop to use exact mapping checks with unique size to avoid race conditions |
| Justfile | Removed explicit runs of newly unignored tests from test-isolated, updated comment for execute_on_heap test |
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
…gger) Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies our
just-file slightly by rewriting and unignoring tests that no longer needs to be ran separately. Reviewing commit-by-commit is probably easiest. Will follow up with another PR that cleans up ourjust-file to avoid running duplicate tests, which wastes a lot of time in CI currently