Automatically clear expired objects#294
Open
007-Heroa wants to merge 2 commits intohyperoslo:masterfrom
Open
Conversation
lukeswitz
added a commit
to lukeswitz/Cache
that referenced
this pull request
Jul 21, 2022
Support expiry hyperoslo#294
|
it will be great if you add some description to the PR. |
ajain26
suggested changes
Feb 2, 2024
ajain26
left a comment
ajain26
left a comment
There was a problem hiding this comment.
Please update the code with latest swift syntex
| } | ||
|
|
||
| public func applyExpiratonMode(_ expirationMode: ExpirationMode) { | ||
| if let didEnterBackgroundObserver = didEnterBackgroundObserver { |
There was a problem hiding this comment.
Suggested change
| if let didEnterBackgroundObserver = didEnterBackgroundObserver { | |
| if let didEnterBackgroundObserver { |
| object: nil, | ||
| queue: nil) | ||
| { [weak self] _ in | ||
| guard let `self` = self else { return } |
There was a problem hiding this comment.
Suggested change
| guard let `self` = self else { return } | |
| guard let self else { return } |
|
|
||
| public extension Storage { | ||
| func applyExpiratonMode(_ expirationMode: ExpirationMode) { | ||
| self.hybridStorage.applyExpiratonMode(expirationMode) |
There was a problem hiding this comment.
Suggested change
| self.hybridStorage.applyExpiratonMode(expirationMode) | |
| hybridStorage.applyExpiratonMode(expirationMode) |
| NotificationCenter.default.addObserver(forName: UIApplication.didEnterBackgroundNotification, | ||
| object: nil, | ||
| queue: nil) { [weak self] _ in | ||
| guard let `self` = self else { return } |
There was a problem hiding this comment.
Suggested change
| guard let `self` = self else { return } | |
| guard let self else { return } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.