types: re-add @types/hoist-non-react-statics to dependencies#2316
Merged
adrai merged 1 commit intoi18next:masterfrom Feb 6, 2025
Merged
types: re-add @types/hoist-non-react-statics to dependencies#2316adrai merged 1 commit intoi18next:masterfrom
@types/hoist-non-react-statics to dependencies#2316adrai merged 1 commit intoi18next:masterfrom
Conversation
Member
|
@Erik-Gro fyi |
Member
|
thank you, it's included in v15.4.2 |
Contributor
|
@adrai @marcalexiei thanks for the information |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2315
Reverts #2310
From #2310:
This is generally true, however
next-i18nextactually relies on types fromhoist-non-react-staticswhich are exposed to the user:next-i18next/src/appWithTranslation.tsx
Line 2 in fe1b79a
next-i18next/src/appWithTranslation.tsx
Line 129 in fe1b79a
If types are not included when installing the library, users will experience types errors,
that might be hidden if
skipLibChecktypescript compiler option is set totrue(like in #2315).If you don't want that
@typespackage is always installed you should usepeerDependenciesalongsidepeerDependenciesMeta.However, this will require user to manually install
@typespackage,so a mention to this should be added in all relevant places.
Checklist
npm run test