adding support for 1x2 widget size for history widget#1514
Open
pphu wants to merge 2 commits intoiSoron:devfrom
Open
adding support for 1x2 widget size for history widget#1514pphu wants to merge 2 commits intoiSoron:devfrom
pphu wants to merge 2 commits intoiSoron:devfrom
Conversation
Collaborator
If that's the case, can you branch on the Android version depending on that, such that the magic only happens for Android 12 and lesser? This way we can remove the magic eventually, once we upgrade the SDK. |
Owner
|
Thanks for the PR, @pphu. The implementation looks good to me, but I think we need unit tests for |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for 1x2 history widget size by using Java Calendar's NARROW_FORMAT when getting narrow. From discussion #1513

I've been removed from Android development for many years but from what I can tell, Android 13 has better support for widget size. However since the min SDK is Android 9, I'm using the
width < 80to determine if the widget size is less than 2 cells wide. The default widget size is currently at 80 and that rounds to 2 cells wide. It's a little too magical for my taste but if anyone has a suggestion, please let me know.