-
Notifications
You must be signed in to change notification settings - Fork 2
Add advancedUsage to standard layout of ToolbarItem
#1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GerardasB
wants to merge
28
commits into
master
Choose a base branch
from
gerardas/toolbar-placement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advancedUsage to standard layout of ToolbarItemadvancedUsage to standard layout of ToolbarItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds an optional
advancedUsageproperty to theStandardLayoutToolbarIteminterface. It takes precedence over standard toolbar usages described inToolbarUsageenum. The new property type is extensible: allows custom values to be used and new string literal types defined in the union type."view-settings"advanced usage type is introduced to display toolbars in the bottom-right area of the content.Known issues
Preview
https://itwin.github.io/appui/1474/?path=/story/frontstage-toolbars--all