support for Values keyword

[naronchen]

#897

[naronchen]

WIP

[naronchen]

i can also just append the resolved path here?

[khanaffan]

Here is some test we should add in this PR

1. SELECT column1, column2 FROM (VALUES(1,2)) UNION SELECT column1, column2 FROM (VALUES(3,4));
2. SELECT * FROM (SELECT column1 a, column2 b FROM (VALUES(1,2)))
3. SELECT * FROM (VALUES(1,2)) a, (VALUES(2,3)) b
4. SELECT * FROM (VALUES(1,2)) a, (VALUES(2,3)) b WHERE a.Column2=2
5. SELECT * FROM (VALUES(?,?),(?,?)) a bind parameter and test

[khanaffan]

report this as issue for future work

I also noted that following, but column1_1 or column2_1 cannot be accessed in WHERE clause instead we have to use b.column1 and b.column2 to access it.

iModelConsole> SELECT * FROM (VALUES(1,2)) a, (VALUES(2,3)) b;

column1           |column2           |column1_1         |column2_1
---------------------------------------------------------------------------
1                 |2                 |2                 |3

[khanaffan]

This should be fixed in this PR.

There is no type checking e.g. Normally if a user uses a different type for the same column in different rows and its constant literal then we should fail if the type is different.

iModelConsole> .metadata SELECT * FROM (VALUES('dd',2),('333',4)) a;

Column metadata
===============
Index   Name/PropertyPath                   DisplayLabel                        System   Type                      Root class                     Root class alias
------------------------------------------------------------------------------------------------------------------------------------------------------------------
  0     column1                             column1                             no       String                    generated
  1     column2                             column2                             no       Long                      generated

[akshay-nangare]

There is no type checking e.g. Normally if a user uses a different type for the same column in different rows and its constant literal then we should fail if the type is different.

I checked this in SQLite playground and SELECT * FROM (VALUES('dd',2),('333',4)) a; query passes on 4 different playgrounds.

SQLite uses dynamic typing and a concept called type affinity. This means that even if you declare a column to be of a certain type (e.g., INTEGER), SQLite will not strictly enforce it. You can insert different types (e.g., string, float, blob) into that column without errors.

[khanaffan]

I added few mandory work that include add test and validate type of constant literal provided as values if more than one row is specified.