Support for running against libnode.dll #904
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jffmarker is this still needed? |
Member
|
@swbsi do we still need this chnage? |
Contributor
Author
We now have the napi api exposed through the mstn exe. So, we do not need this for local sync presently. However, to keep pace with the addon ecosystem, we should probably make the change. Node-gyp has added support for libnode.dll, for example (nodejs/node-gyp#2834). |
aruniverse
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convention of GetModuleHandle(NULL) in addon delay load handlers (https://github.com/nodejs/node-gyp/blob/e6f4ede10cca28e9edeaa85d7830914c5d1499c7/src/win_delay_load_hook.cc#L31) does not work when node is built as a shared library on windows in an embedding scenario, since the napi_* APIs are then defined in a dll, not the host exe.